logicamp/flink-kube-operator
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve leftover jar file issue after upload

Browse Source
This commit is contained in:
Mohamad Khani 2024-12-13 20:12:52 +03:30
parent 9f36dca7c9
commit 9086f6664e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/jar/jar.go
View File

@ -41,7 +41,6 @@ func (jarFile *JarFile) Upload(flinkClient *api.Client) (fileName string, err er
if resp.Status != "success" { if resp.Status != "success" {
err = errors.New("jar upload was not success") err = errors.New("jar upload was not success")
} }
jarFile.filePath = fileName
jarFile.delete() jarFile.delete()
return return
} }
@ -56,8 +55,8 @@ func (jarFile *JarFile) Download() error {
defer out.Close() defer out.Close()
resp, err := http.Get(jarFile.uri) resp, err := http.Get(jarFile.uri)
if err != nil || resp.StatusCode > 200 { if err != nil || resp.StatusCode > 299 {
os.Remove(jarFile.filePath) jarFile.delete()
return err return err
} }
@ -70,7 +69,10 @@ func (jarFile *JarFile) Download() error {
} }
func (jarFile *JarFile) delete() error { func (jarFile *JarFile) delete() error {
pkg.Logger.Info("[jar] [delete]", zap.String("path", jarFile.filePath))
err := os.Remove(jarFile.filePath) err := os.Remove(jarFile.filePath)
pkg.Logger.Debug("[jar] [delete]", zap.Error(err)) if err != nil {
pkg.Logger.Error("[jar] [delete]", zap.Error(err))
}
return err return err
} }