From 9086f6664e12c7992cbe474b7fb16fcfd29f1203 Mon Sep 17 00:00:00 2001
From: Mohammadreza Khani <mohamadkhani14@gmail.com>
Date: Fri, 13 Dec 2024 20:12:52 +0330
Subject: [PATCH] fix: resolve leftover jar file issue after upload

---
 internal/jar/jar.go | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/internal/jar/jar.go b/internal/jar/jar.go
index f579c33..438624b 100644
--- a/internal/jar/jar.go
+++ b/internal/jar/jar.go
@@ -41,7 +41,6 @@ func (jarFile *JarFile) Upload(flinkClient *api.Client) (fileName string, err er
 	if resp.Status != "success" {
 		err = errors.New("jar upload was not success")
 	}
-	jarFile.filePath = fileName
 	jarFile.delete()
 	return
 }
@@ -56,8 +55,8 @@ func (jarFile *JarFile) Download() error {
 
 	defer out.Close()
 	resp, err := http.Get(jarFile.uri)
-	if err != nil || resp.StatusCode > 200 {
-		os.Remove(jarFile.filePath)
+	if err != nil || resp.StatusCode > 299 {
+		jarFile.delete()
 		return err
 	}
 
@@ -70,7 +69,10 @@ func (jarFile *JarFile) Download() error {
 }
 
 func (jarFile *JarFile) delete() error {
+	pkg.Logger.Info("[jar] [delete]", zap.String("path", jarFile.filePath))
 	err := os.Remove(jarFile.filePath)
-	pkg.Logger.Debug("[jar] [delete]", zap.Error(err))
+	if err != nil {
+		pkg.Logger.Error("[jar] [delete]", zap.Error(err))
+	}
 	return err
 }