fix(helm): wrong savepoint path config when storage-type is filesystem

helm/chart/Chart.yaml

@@ -2,9 +2,5 @@ apiVersion: v2
 name: flink-kube-operator
 description: Helm chart for flink kube operator
 type: application
-version: 1.1.1
+version: 1.2.3
 appVersion: "0.1.1"
-dependencies:
-  - name: minio
-    repository: https://charts.bitnami.com/bitnami
-    version: 16.0.2 

helm/chart/templates/flink/checkpoint-pvc.yaml

@@ -1,3 +1,4 @@
+{{- if eq .Values.flink.state.checkpoint.storageType "filesystem" }}
 apiVersion: v1
 kind: PersistentVolumeClaim
 metadata:
@@ -8,3 +9,4 @@ spec:
   resources:
     requests:
       storage: {{ .Values.flink.state.checkpoint.size }}
+{{- end }}

helm/chart/templates/flink/config.yaml

@@ -27,11 +27,17 @@
     {{- end }}
     state.backend.rocksdb.localdir: /opt/flink/rocksdb
     high-availability.storageDir: /opt/flink/ha
+    {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
+    state.savepoints.dir: file:///opt/flink/savepoints/
+    {{- else if eq .Values.flink.state.savepoint.storageType "s3" }}
     state.savepoints.dir: s3://flink/savepoints/
+    {{- end }}
     state.backend.incremental: {{ .Values.flink.state.incremental }}
     rest.profiling.enabled: true
+    {{- if or (eq .Values.flink.state.checkpoint.storageType "s3") (eq .Values.flink.state.savepoint.storageType "s3") }}
     s3.endpoint: http://{{ .Release.Name }}-minio:9000
     s3.path.style.access: true
+    {{- end }}
     {{- toYaml .Values.flink.properties | default "" | nindent 4 }}
     
 {{- end }}

helm/chart/templates/flink/job-manager-deploy.yaml

@@ -49,6 +49,7 @@ spec:
               valueFrom:
                 fieldRef:
                   fieldPath: status.podIP
+            {{- if or (eq .Values.flink.state.checkpoint.storageType "s3") (eq .Values.flink.state.savepoint.storageType "s3") }}
             - name: S3_ENDPOINT
               value: "http://minio-service:9000"
             - name: AWS_ACCESS_KEY_ID
@@ -61,6 +62,7 @@ spec:
                 secretKeyRef:
                   name: {{ .Release.Name }}-flink-secrets
                   key: minio_secret_key
+            {{- end }}
           volumeMounts:
             - name: flink-ha
               mountPath: {{ .Values.flink.state.ha.dir }}
@@ -68,6 +70,10 @@ spec:
             - name: flink-checkpoint
               mountPath: /opt/flink/checkpoints
             {{- end }}
+            {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
+            - name: flink-savepoint
+              mountPath: /opt/flink/savepoints
+            {{- end }}
       volumes:
         - name: flink-ha
           persistentVolumeClaim:
@@ -77,6 +83,11 @@ spec:
           persistentVolumeClaim:
             claimName: {{ .Release.Name }}-flink-checkpoint-pvc
         {{- end }}
+        {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
+        - name: flink-savepoint
+          persistentVolumeClaim:
+            claimName: {{ .Release.Name }}-flink-savepoint-pvc
+        {{- end }}
       {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}

helm/chart/templates/flink/savepoint-pvc.yaml

@@ -0,0 +1,12 @@
+{{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: {{ .Release.Name }}-flink-savepoint-pvc
+spec:
+  accessModes:
+    - ReadWriteMany
+  resources:
+    requests:
+      storage: {{ .Values.flink.state.savepoint.size }}
+{{- end }}

helm/chart/templates/flink/task-manager-statefulset.yaml

@@ -31,6 +31,7 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: status.podIP
+        {{- if or (eq .Values.flink.state.checkpoint.storageType "s3") (eq .Values.flink.state.savepoint.storageType "s3") }}
         - name: S3_ENDPOINT
           value: "http://minio-service:9000"
         - name: AWS_ACCESS_KEY_ID
@@ -43,6 +44,7 @@ spec:
             secretKeyRef:
               name: {{ .Release.Name }}-flink-secrets
               key: minio_secret_key
+        {{- end }}
         volumeMounts:
         - name: rocksdb-storage
           mountPath: /opt/flink/rocksdb
@@ -50,14 +52,24 @@ spec:
         - name: flink-checkpoint
           mountPath: /opt/flink/checkpoints
         {{- end }}
+        {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
+        - name: flink-savepoint
+          mountPath: /opt/flink/savepoints
+        {{- end }}
         resources:
           {{- toYaml .Values.flink.taskManager.resources | nindent 10 }}
-      {{- if eq .Values.flink.state.checkpoint.storageType "filesystem" }}
       volumes:
+        {{- if eq .Values.flink.state.checkpoint.storageType "filesystem" }}
         - name: flink-checkpoint
           persistentVolumeClaim:
             claimName: {{ .Release.Name }}-flink-checkpoint-pvc
-      {{- end }}
+        {{- end }}
+        {{- if eq .Values.flink.state.savepoint.storageType "filesystem" }}
+        - name: flink-savepoint
+          persistentVolumeClaim:
+            claimName: {{ .Release.Name }}-flink-savepoint-pvc
+        {{- end }}
+      
   volumeClaimTemplates:
   - metadata:
       name: rocksdb-storage

helm/chart/templates/operator/statefulset.yaml

@@ -46,10 +46,11 @@ spec:
           env:
             - name: FLINK_API_URL
               value: {{ .Release.Name }}-flink-job-manager:8081
-            - name: SAVEPOINT_PATH
-              value: s3://flink/savepoints/
             - name: NAMESPACE
               value: "{{ .Release.Namespace }}"
+            {{- if eq .Values.flink.state.savepoint.storageType "s3" }}
+            - name: SAVEPOINT_PATH
+              value: s3://flink/savepoints/
             - name: S3_ENDPOINT
               value: "http://{{ .Release.Name }}-minio:9000"
             - name: AWS_ACCESS_KEY_ID
@@ -62,5 +63,8 @@ spec:
                 secretKeyRef:
                   name: {{ .Release.Name }}-minio
                   key: root-password
-
+            {{- else }}
+            - name: SAVEPOINT_PATH
+              value: /opt/flink/savepoints/
+            {{- end }}
 

helm/chart/values.yaml

@@ -38,8 +38,7 @@ podAnnotations: {}
 # For more information checkout: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
 podLabels: {}
 
-podSecurityContext: {}
-  # fsGroup: 2000
+podSecurityContext: {} # fsGroup: 2000
 
 securityContext: {}
   # capabilities:
@@ -64,10 +63,10 @@ ingress:
     # kubernetes.io/ingress.class: nginx
     # kubernetes.io/tls-acme: "true"
   hosts:
-    - host: chart-example.local
-      paths:
-        - path: /
-          pathType: ImplementationSpecific
+  - host: chart-example.local
+    paths:
+    - path: /
+      pathType: ImplementationSpecific
   tls: []
   #  - secretName: chart-example-tls
   #    hosts:
@@ -106,7 +105,6 @@ autoscaling:
 config:
   flinkApiUrl: flink:8081
 
-
 nodeSelector: {}
 
 tolerations: []
@@ -120,13 +118,13 @@ flink:
     tag: 1.20.1-scala_2.12-java17-minicluster
 
   parallelism:
-    default: 1  # Default parallelism for Flink jobs
+    default: 1 # Default parallelism for Flink jobs
 
   state:
-    backend: rocksdb  # Use RocksDB for state backend
+    backend: rocksdb # Use RocksDB for state backend
     incremental: true
     ha:
-      dir: "/opt/flink/ha"  # Directory to store ha data
+      dir: "/opt/flink/ha" # Directory to store ha data
       pvcName: flink-ha-pvc # PVC for ha
       size: 10Gi # PVC size for ha
     checkpoint:
@@ -134,25 +132,27 @@ flink:
       interval: 5min
       mode: EXACTLY_ONCE
       size: 8Gi
-      
+    savepoint:
+      storageType: s3
+      size: 8Gi
+
   jobManager:
     processMemory: 4096m # Size of job manager process memory
 
   properties:
     jobmanager.rpc.timeout: 300s
 
-
   taskManager:
-    numberOfTaskSlots: 12  # Number of task slots for task manager
+    numberOfTaskSlots: 12 # Number of task slots for task manager
     processMemory: 4096m # Size of task manager process memory
     replicas: 1 # Number of task manager replicas
     storage:
       rocksDb:
         size: 4Gi
-    resources: 
+    resources:
       limits:
         cpu: 3
         memory: 4Gi
       requests:
         cpu: 1
-        memory: 2Gi
+        memory: 2Gi

helm/index.yaml

@@ -3,18 +3,62 @@ entries:
   flink-kube-operator:
   - apiVersion: v2
     appVersion: 0.1.1
-    created: "2025-04-13T10:37:39.948174933+03:30"
+    created: "2025-07-18T18:09:46.27166563+03:30"
+    description: Helm chart for flink kube operator
+    digest: 597f2c07884bb5411dcc6e1a9cdf7672977858efe30273a46fb6525eb6013091
+    name: flink-kube-operator
+    type: application
+    urls:
+    - flink-kube-operator-1.2.3.tgz
+    version: 1.2.3
+  - apiVersion: v2
+    appVersion: 0.1.1
+    created: "2025-05-17T14:34:55.317942453+03:30"
+    description: Helm chart for flink kube operator
+    digest: 422a34dc173ebe29adccd46d7ef94505cc022ff20ccbfb85ac3e6e201cba476c
+    name: flink-kube-operator
+    type: application
+    urls:
+    - flink-kube-operator-1.2.2.tgz
+    version: 1.2.2
+  - apiVersion: v2
+    appVersion: 0.1.1
+    created: "2025-05-17T14:01:29.891695937+03:30"
+    description: Helm chart for flink kube operator
+    digest: 404ed2c28ff43b630b44c1215be5369417a1b9b2747ae24e2963a6b81813e7dc
+    name: flink-kube-operator
+    type: application
+    urls:
+    - flink-kube-operator-1.2.1.tgz
+    version: 1.2.1
+  - apiVersion: v2
+    appVersion: 0.1.1
+    created: "2025-05-17T12:47:25.848097207+03:30"
     dependencies:
     - name: minio
       repository: https://charts.bitnami.com/bitnami
       version: 16.0.2
     description: Helm chart for flink kube operator
-    digest: 0b5f5e707279a564ad9e6c10fb3e565ff1af0ba2058b3f4bc04546dc8db8f68c
+    digest: 3458b9be97d2a4bcf8574706e44ea9f7fdeb11e83058a615566e6e094a51b920
     name: flink-kube-operator
     type: application
     urls:
-    - flink-kube-operator-1.1.1.tgz
-    version: 1.1.1
+    - flink-kube-operator-1.2.0.tgz
+    version: 1.2.0
+  - apiVersion: v2
+    appVersion: 0.1.1
+    created: "2025-04-15T12:06:59.425538953+03:30"
+    dependencies:
+    - name: minio
+      repository: https://charts.bitnami.com/bitnami
+      version: 16.0.2
+    description: Helm chart for flink kube operator
+    digest: 2b307a113476eebb34f58308bf1d4d0d36ca5e08fe6541f369a1c231ae0a71be
+    name: flink-kube-operator
+    type: application
+    urls:
+    - flink-kube-operator-1.1.2.tgz
+    version: 1.1.2
   - apiVersion: v2
     appVersion: 0.1.1
     created: "2025-04-12T23:13:39.394371646+03:30"
@@ -193,4 +237,4 @@ entries:
     urls:
     - flink-kube-operator-0.1.0.tgz
     version: 0.1.0
-generated: "2025-04-13T10:37:39.928098588+03:30"
+generated: "2025-07-18T18:09:46.244672127+03:30"