From 54008669cbdcf7a27cdabc3ccec3b93ec5897df8 Mon Sep 17 00:00:00 2001
From: Mohammadreza Khani <mohamadkhani14@gmail.com>
Date: Sun, 6 Apr 2025 01:49:00 +0330
Subject: [PATCH] fix(helm): wrong savepoint and checkpoint s3 configs

---
 helm/chart/templates/flink/config.yaml         | 8 +++-----
 helm/chart/templates/operator/statefulset.yaml | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/helm/chart/templates/flink/config.yaml b/helm/chart/templates/flink/config.yaml
index d7d77dc..d128807 100644
--- a/helm/chart/templates/flink/config.yaml
+++ b/helm/chart/templates/flink/config.yaml
@@ -20,14 +20,12 @@
     kubernetes.cluster-id: {{ .Values.clusterId | default (print .Release.Name "-cluster") }}
     execution.checkpointing.interval: {{ .Values.flink.checkpoint.interval }}
     execution.checkpointing.mode: {{ .Values.flink.checkpoint.mode }}
-    state.checkpoints.dir: s3://{{ .Release.Name }}-minio:9000/checkpoints
+    state.checkpoints.dir: s3://flink/checkpoints/
     state.backend.rocksdb.localdir: /opt/flink/rocksdb
     high-availability.storageDir: /opt/flink/ha
-    state.savepoints.dir: s3://{{ .Release.Name }}-minio:9000/savepoints
+    state.savepoints.dir: s3://flink/savepoints/
     state.backend.incremental: {{ .Values.flink.state.incremental }}
     rest.profiling.enabled: true
-    s3.endpoint: http://{{ .Release.Name }}-minio:9000  # Use Kubernetes service name
+    s3.endpoint: http://{{ .Release.Name }}-minio:9000
     s3.path.style.access: true
-    s3.fs.hadoop.impl: org.apache.hadoop.fs.s3a.S3AFileSystem  # Keep for compatibility
-    fs.s3a.aws.credentials.provider: com.amazonaws.auth.DefaultAWSCredentialsProviderChain
 {{- end }}
diff --git a/helm/chart/templates/operator/statefulset.yaml b/helm/chart/templates/operator/statefulset.yaml
index 4b90465..c50f097 100644
--- a/helm/chart/templates/operator/statefulset.yaml
+++ b/helm/chart/templates/operator/statefulset.yaml
@@ -47,7 +47,7 @@ spec:
             - name: FLINK_API_URL
               value: {{ .Release.Name }}-flink-job-manager:8081
             - name: SAVEPOINT_PATH
-              value: s3://{{ .Release.Name }}-minio:9000/savepoints
+              value: s3://flink/savepoints/
             - name: NAMESPACE
               value: "{{ .Release.Namespace }}"
             - name: S3_ENDPOINT