From 0993ed4cb1e8f7ab696a27582b3354815c5ae184 Mon Sep 17 00:00:00 2001 From: Mohammadreza Khani Date: Sun, 8 Dec 2024 19:25:31 +0330 Subject: [PATCH] fix(jar): bug on remove temporary jar --- internal/jar/jar.go | 1 + internal/managed_job/run.go | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/jar/jar.go b/internal/jar/jar.go index 54fad6c..5686a18 100644 --- a/internal/jar/jar.go +++ b/internal/jar/jar.go @@ -40,6 +40,7 @@ func (JarFile *JarFile) Upload(flinkClient *api.Client) (fileName string, err er if resp.Status != "success" { err = errors.New("jar upload was not success") } + JarFile.filePath = fileName return } diff --git a/internal/managed_job/run.go b/internal/managed_job/run.go index 3236abd..efb4ad1 100644 --- a/internal/managed_job/run.go +++ b/internal/managed_job/run.go @@ -18,11 +18,14 @@ func (job *ManagedJob) upload() error { return err } fileName, err := jarFile.Upload(job.client) - jarFile.Delete() if err != nil { lc.Logger.Debug("[main] error on upload jar", zap.Error(err)) return err } + err = jarFile.Delete() + if err != nil { + lc.Logger.Debug("[main] error on delete jar", zap.Error(err)) + } lc.Logger.Debug("[main] after upload jar", zap.Any("upload-jar-resp", fileName)) job.def.Status.JarId = &fileName