logicamp/flink-kube-operator
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve remain jar file after upload

Browse Source
This commit is contained in:
Mohamad Khani 2024-12-13 19:51:26 +03:30
parent d36b9c30df
commit 02d8f0b02e
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/jar/jar.go
View File

@ -30,9 +30,9 @@ func NewJarFile(URI string) (*JarFile, error) {
return jarFile, nil return jarFile, nil
} }
func (JarFile *JarFile) Upload(flinkClient *api.Client) (fileName string, err error) { func (jarFile *JarFile) Upload(flinkClient *api.Client) (fileName string, err error) {
resp, err := flinkClient.UploadJar(JarFile.filePath) resp, err := flinkClient.UploadJar(jarFile.filePath)
if err != nil { if err != nil {
pkg.Logger.Error("[main] error uploading jar", zap.Error(err)) pkg.Logger.Error("[main] error uploading jar", zap.Error(err))
} }
@ -41,13 +41,14 @@ func (JarFile *JarFile) Upload(flinkClient *api.Client) (fileName string, err er
if resp.Status != "success" { if resp.Status != "success" {
err = errors.New("jar upload was not success") err = errors.New("jar upload was not success")
} }
JarFile.filePath = fileName jarFile.filePath = fileName
jarFile.delete()
return return
} }
func (jarFile *JarFile) Download() error { func (jarFile *JarFile) Download() error {
fileName, _ := gonanoid.New() fileName, _ := gonanoid.New()
jarFile.filePath = fileName + ".jar" jarFile.filePath = "/tmp/" + fileName + ".jar"
out, err := os.Create(jarFile.filePath) out, err := os.Create(jarFile.filePath)
if err != nil { if err != nil {
return err return err
@ -68,6 +69,8 @@ func (jarFile *JarFile) Download() error {
return nil return nil
} }
func (jarFile *JarFile) Delete() error { func (jarFile *JarFile) delete() error {
return os.Remove(jarFile.filePath) err := os.Remove(jarFile.filePath)
pkg.Logger.Debug("[jar] [delete]", zap.Error(err))
return err
} }

4
internal/managed_job/upload.go
View File

@ -20,10 +20,6 @@ func (job *ManagedJob) upload() error {
pkg.Logger.Debug("[manage-job] [upload] error on upload jar", zap.Error(err)) pkg.Logger.Debug("[manage-job] [upload] error on upload jar", zap.Error(err))
return err return err
} }
err = jarFile.Delete()
if err != nil {
pkg.Logger.Debug("[manage-job] [upload] error on delete jar", zap.Error(err))
}
pkg.Logger.Info("[manage-job] [upload] uploaded", zap.Any("upload-jar-resp", jarId)) pkg.Logger.Info("[manage-job] [upload] uploaded", zap.Any("upload-jar-resp", jarId))
job.def.Status.JarId = &jarId job.def.Status.JarId = &jarId